Re: [U-Boot] [PATCH] omap_hsmmc: Check wp and cd GPIO for -1

On Wed, Mar 20, 2013 at 03:37:10PM -0300, Fabio Estevam wrote:

On Wed, Mar 20, 2013 at 3:32 PM, Tom Rini trini@ti.com wrote:

...

    int cd_gpio = ((struct omap_hsmmc_data *)mmc->priv)->cd_gpio;

•   return gpio_get_value(cd_gpio);
  

•   if (cd_gpio >= 0)
  

What about using gpio_is_valid(cd_gpio) ?

OK, good point.

...

•           return gpio_get_value(cd_gpio);
  

•   else
  

•           return -1;
  

What about -EINVAL?

Not consistent with the rest of the driver, so I'll do that in a 2/2. Thanks!