
18 Dec
2010
18 Dec
'10
5:07 p.m.
On Fri, Dec 17, 2010, Wolfgang Denk wrote:
Thanks for the fix. A tiny change request, though:
- @rm -f $(obj)include/asm/proc $(obj)include/asm/arch $(obj)include/asm
- @rm -f $(obj)include/asm/proc $(obj)include/asm/arch
- @[ ! -h $(obj)include/asm ] || rm -f $(obj)include/asm
- @[ ! -d $(obj)include/asm ] || rmdir $(obj)include/asm
Don't make it that complicated. Just change the line into @rm -fr$(obj)include/asm/proc $(obj)include/asm/arch $(obj)include/asm
I think I had this in my first version, but had an issue with it; I will retest
Also a question: how has this change been tested?
I did something like: a) start fresh: git clean -x -d b) configure with or without objdir make CROSS_COMPILE=arm-linux-gnueabi- O=$PWD/obj omap3_beagle_config c) build (with or without objdir) d) distclean (with or without objdir)
and tested combinations like a-d-d, a-b-d-d, a-b-c-d-d, then checked whether any file remained with git clean -x -d -n
--
Loïc Minier