On May 14, 2008, at 3:54 PM, Kim Phillips wrote:
On Wed, 14 May 2008 15:31:43 -0500 Becky Bruce becky.bruce@freescale.com wrote:
On May 14, 2008, at 1:57 PM, Kim Phillips wrote:
On Wed, 14 May 2008 13:10:04 -0500 becky.bruce@freescale.com wrote:
From: Becky Bruce becky.bruce@freescale.com
Currently, END_OF_RAM is used by the trap code to determine if we should attempt to access the stack pointer or not. However, on systems with a lot of RAM, only a subset of the RAM is guaranteed to be mapped in and accessible. Change END_OF_RAM to use get_effective_memsize() instead of using the raw ram size out of the bd.
Signed-off-by: Becky Bruce becky.bruce@freescale.com
what, no love for 4xx, 83xx, and 74xx_7xx?
The other platforms currently set a hard limit that should still be valid - I just changed the ones that were reading memsize directly out of the bd.
sure, 5xx, 82xx and 8xx are hardcoded, but 74xx_7xx (albeit only AMIGAONE), all 83xx, and all 4xx use the bd just like in your current patchseries. I'm just trying to maintain some level of consistency.
74xx_7xx only does it if CONFIG_AMIGA-something-or-the other is defined, and I have no idea about that particular platform, so I left it alone in that case. Otherwise 74xx_7xx hardcodes it. I actually think perhaps the right answer there is to change the whole thing to use get_effective_memsize in both cases. Does anyone have a contrary opinion on this.
You're right that I missed 83xx, and I will patch that one (sorry, too much grep output, and I missed this one).
I'm also happy to do 4xx if we're pretty sure this it The Right Thing (TM).
Cheers, B