Re: [U-Boot] [PATCH] Fix GCC format-security errors.

Dear Ben,

In message 1451399667-32519-1-git-send-email-ben.whitten@gmail.com you wrote:

From: Ben Whitten ben.whitten@gmail.com

With format-security errors turned on, GCC picks up the use of sprintf without a format parameter.

Thanks for detecting this, but...

• 		ptr = sprintf(build_buf, tmp);
  

• 		ptr = sprintf(build_buf, "%s", tmp);
  

...

• 		ptr += sprintf(build_buf + ptr, tmp);
  

• 		ptr += sprintf(build_buf + ptr, "%s", tmp);
  

... why should we use sprintf() here at all? I recommend to convert this into a plain strcpy().

Best regards,

Wolfgang Denk