Re: [PATCH] sandbox: disable tracing before unmapping RAM

Hi Simon,

Simon Glass sjg@chromium.org says:

On Wed, 12 Apr 2023 at 12:55, Pavel Skripkin paskripkin@gmail.com wrote:

...

Currently doing 'reset' command in sandbox with tracing enabled causes SIGSEV

Hit any key to stop autoboot:  0
=>
=>
=> reset
resetting ...
Segmentation fault (core dumped)

Tracing callback uses RAM buffer for storing tracing reports, but state_uninit() function unmaps whole RAM, which causes SIGSEV on umapped memory inside tracing subsystem.

Fix it by disabling tracing before unmapping memory

Signed-off-by: Pavel Skripkin paskripkin@gmail.com

arch/sandbox/cpu/state.c | 4 ++++ 1 file changed, 4 insertions(+)

Reviewed-by: Simon Glass sjg@chromium.org

Thank you for review!

+Tom, I guess?

@Tom, could you, please, pick following patch?

https://lists.denx.de/pipermail/u-boot/2023-April/515192.html

With regards, Pavel Skripkin