Hello Stefan,
Am 11.11.2014 19:03, schrieb Stefan Roese:
We had the problem on an AM33xx platform, that SPL detected an unsupported boot-device. But since this message is a debug message it took a bit of time to really know, where the hangup in SPL resulted from. So let's change this debug message to a printf and also print the detected boot-device that is not supported. This makes debugging of such cases much easier.
Signed-off-by: Stefan Roese sr@denx.de Cc: Wolfgang Denk wd@denx.de Cc: Tom Rini trini@ti.com
v2:
Added #if check so that the printf is only included when serial support is enabled.
Compile tested on all ARM boards
common/spl/spl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Yes, I think this is a good idea, as I stepped also in the same problem. I tend to first activate debug when I have not working SPL code ... but this is not possible for example on running systems ... on the other side, this problem should raise only in the development state ...
The same for other places ... like UBI ... see my question [1]. It would be nice to have this ubi errormessages enabled, but this cost a lot of space ...
But for this patch, I think it is okay to enable it by default ... so:
Acked-by: Heiko Schocher hs@denx.de
bye, Heiko
[1] [U-Boot] mtd, ubi: errormessage handling https://patchwork.ozlabs.org/patch/405259/
diff --git a/common/spl/spl.c b/common/spl/spl.c index d85bab3..cef7bca 100644 --- a/common/spl/spl.c +++ b/common/spl/spl.c @@ -216,7 +216,9 @@ void board_init_r(gd_t *dummy1, ulong dummy2) break; #endif default:
debug("SPL: Un-supported Boot Device\n");+#if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
printf("SPL: Unsupported Boot Device %d\n", boot_device);+#endif hang(); }