Dear Hatim,
On 17 October 2012 15:26, Hatim Rv rv.hatimali@gmail.com wrote:
Dear Minkyu Kang,
On Wed, Oct 17, 2012 at 10:55 AM, Minkyu Kang promsoft@gmail.com wrote:
Dear Hatim,
On 17 October 2012 14:21, Hatim Rv rv.hatimali@gmail.com wrote:
diff --git a/arch/arm/include/asm/arch-exynos/clk.h b/arch/arm/include/asm/arch-exynos/clk.h index 5529025..4e51402 100644 --- a/arch/arm/include/asm/arch-exynos/clk.h +++ b/arch/arm/include/asm/arch-exynos/clk.h @@ -22,6 +22,8 @@ #ifndef __ASM_ARM_ARCH_CLK_H_ #define __ASM_ARM_ARCH_CLK_H_
+#include <asm/arch/pinmux.h>
no. we don't need this header file.
Actually we do need the asm/arch/periph.h file as we are using the 'enum periph_id'. Otherwise it will give compilation errors.
So, I commented.
"please modify to exynos5_set_spi_clk(int periph_id"
we don't have to use enum at parameter.
Even if we make the enum as int in the clk.h we still need the enum definition in clock.c.
then, please include that file in clock.c
Besides, making the enum as int in clk.h does not look good as it will make the code confusing (by passing enum as int and using int as enum).
No, it's not confusing. enum is not a specific data type. Please look pinmux.c we get paramter as int.
So we require the periph.h declaration either in clk.h or clock.c file. If there is any better way to proceed, please let me know.
Actually, I want what you do not use periph_id at clock.c. Why clock get dependency with pinmux?
Thanks. Minkyu Kang.