Re: [U-Boot] [PATCH v3 1/2] armv7: add support for S5PC210 SoC

Dear Wolfgang Denk,

On 20 January 2011 22:31, Wolfgang Denk wd@denx.de wrote:

Dear Minkyu Kang,

In message 4D382F3E.6080000@samsung.com you wrote:

...

S5PC210 is a 32-bit RISC and Cortex-A9 Dual Core based micro-processor.

...

...

new file mode 100644 index 0000000..69011fc --- /dev/null +++ b/arch/arm/include/asm/arch-s5pc2xx/uart.h

...

...

+static int use_divslot = 0;

This is certainly wrong in a header file.

Also, please do not initialise statics to 0 or NULL.

Hm, how about inline function or macro?

Thanks Minkyu Kang