On Thu, Aug 01, 2024 at 11:16 GMT, Quentin Schulz wrote:
Did you test this? It doesn't match the synopsis section, the help text
of the command and the source code.
Reading the code, pwm enable only expects two arguments, same for pwm disable, so I would assume that the following should be used instead:
pwm enable 0 0 pwm disable 0 0
Did we forget to fix the help text and I misread the code maybe?
Cheers, Quentin
Hi Quentin,
I did indeed test it, and you are correct that pwm enable and disable only expect two arguments. The additional two arguments (20000 14000) were a leftover from copy-pasting that I forgot to delete.
You did not misread anything, but I sent out a v2 patch to address another issue before I got your email.
I will send a v3 patch, which:
- Changes the help text to be explicit about 20 us and 14 us for the period and duty cycle, respectively. - Fixes pwm enable and disable to only expect 2 arguments.
Thanks again.