On Wed, Jan 30, 2019 at 12:24:29AM +0100, Lukasz Majewski wrote:
On Tue, 29 Jan 2019 14:40:08 +0100 Jean-Jacques Hiblot jjhiblot@ti.com wrote:
This series adds support for the creation of symbolic links on ext4 file-systems. The motivation behind this work is to have the ability to "do" the job of update-alternatives in u-boot. Firmware on TI's platform are usually managed with update-alternatives and are thus targeted by a symbolic link. In some situations we need the ability to select an alternate firmware before the linux kernel is started so that when a early driver needing the firmware comes up, it can be fed the firmware of our choice.
Tested on a am57xx_evm, using a EXT4 partition on external SDcard. The filesystem can be checked later with: fsck.ext4 -f <dev>
usage example: => ln mmc 0:2 zImage /boot/the_linux_kernel
Could you also add a test for symlink to sandbox? This is a high level code (FS ext4), so it can be nice tested there.
Jean-Jacques Hiblot (3): fs: ext4: constify the buffer passed to write functions fs: ext4: Add support for the creation of symbolic links fs: Add a new command to create symbolic links
cmd/fs.c | 14 ++++++++++++ fs/ext4/ext4_common.c | 6 ++--- fs/ext4/ext4_common.h | 2 +- fs/ext4/ext4_write.c | 51 ++++++++++++++++++++++++++++++++----------- fs/fs.c | 44 +++++++++++++++++++++++++++++++++++++ include/ext4fs.h | 5 +++-- include/fs.h | 2 ++ 7 files changed, 105 insertions(+), 19 deletions(-)
Yes, now that we have tests under pytest, we need to drop something for this under test/py/tests/test_fs/ and my first thought is in a new test_symlink.py file so that someday when we get more than just FAT/EXTn tests the next FS that supports symlinks gets the tests for free if/when it supports symlinks.