2017-12-08 17:54 GMT+01:00 Stephen Warren swarren@wwwdotorg.org:
On 12/08/2017 07:47 AM, Michal Simek wrote:
Some QEMUs have a problem with time setup that's why sleep test is failing. Introduce env__sleep_accurate boardenv variable to have an option to skip sleep test.
Nit: Commit descriptions are typically wrapped around 70-74 characters; the above is very narrow.
diff --git a/test/py/tests/test_sleep.py b/test/py/tests/test_sleep.py
+"""
+Note: This test doesn't rely on boardenv_* configuration values but they can +change test behavior.
+# Setup env__sleep_accurate to False if time is not accurate on your platform +env__sleep_accurate = False
+"""
Nit: No need for that trailing empty line in the docstring.
Reviewed-by: Stephen Warren swarren@nvidia.com
(I was going to contemplate a more generic system implemented in conftest.py that could work with any test, but I guess this is simple enough and solves the only issue we have right now, so it's fine.)
I think also that generic solution would be better. I was checking xilinx repo where we have some simple i2c device tests which also needs to be run based on platforms. This test is broken on qemu and some boards are also broken. There is not an issue with travis because sleep tests are disabled now. For my qemu testing it is not big deal and I can use -k not sleep or this patch as temporary workaround till we have generic solution in place.
Thanks, Michal