Hi Ben,
On Saturday 22 March 2008, Ben Warren wrote:
Add new board_eth_init() function, moving all TSEC initializations to board code.
I would prefer to move this init code not into the board code but into the platform/cpu code. Speaking for PPC4xx, here all configuration I know of have the same init code. And copying this into all board ports instead on one place in the cpu directory seems "imperfect".
Using a weak definition for this board_eth_init() would make this possible. The cpu code would define the function with the default 4xx init code, and the board code could overwrite it. But unfortunately you already introduced such a weak reference to this function in eth.c.
How can this be handled better? Any ideas?
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================