Hi, Ben.
Thank you for your check.
2008/6/10 Ben Warren bwarren@qstreams.com:
Hi Nobuhiro,
Nobuhiro Iwamatsu wrote:
Renesas SH7763 has 2 channel Ethernet device. This is 10/100/1000 Base support. But this patch check 10/100 Base only.
Where's the code that has this driver being initialized by net/eth.c? Is it in another patch or should I just go to bed?
Yes , this driver initialize used eth_init. Thank you.
<snip>
This code has quite a few magic numbers. Considering that you're submitting a header file too, it's hard to justify not adding mnemonics.
<snip>
Another magic number that should be a #defined bit mask
Thanks. I will rewrite and cleanup soruce code.
<snip>
diff --git a/drivers/net/sh_eth.h b/drivers/net/sh_eth.h new file mode 100644 index 0000000..12a4528 --- /dev/null +++ b/drivers/net/sh_eth.h @@ -0,0 +1,195 @@
<snip>
Please use the accessors in include/asm-sh/io.h instead of defining your own.
OK.
I revise the place that you pointed out and resend it. I thank for your check.
Best regards, Nobuhiro