31 Mar
2008
31 Mar
'08
8:18 p.m.
On Mon, 31 Mar 2008 10:01:34 -0400 Ben Warren biggerbadderben@gmail.com wrote:
Tor Krill wrote:
Add phy_info for Vitesse VSC8601. Add config option, CFG_VSC8601_SKEWFIX, to enable RGMII skew timing compensation.
Signed-off-by: Tor Krill tor@excito.com
Acked-by: Ben Warren biggerbadderben@gmail.com
I don't have a Vitesse 8601, so technically I can't ack it, but I can:
Reviewed-by: Kim Phillips kim.phillips@freescale.com
minor nit: it would be nice if the following:
+#ifdef CFG_VSC8601_SKEWFIX
{MIIM_VSC8601_EPHY_CON,MIIM_VSC8601_EPHY_CON_INIT_SKEW,NULL},+#endif
were made to have spaces after commas, and flow onto a separate line so as to not be a 96 char line..
Kim