On Friday, October 14, 2011 11:00:35 PM Wolfgang Denk wrote:
Dear Marek Vasut,
In message 201110140959.42368.marek.vasut@gmail.com you wrote:
Running checkpatch on your patches I see a lot of issues, and not only a couple of them.
For example,
WARNING: line over 80 characters #632: FILE: arch/arm/cpu/arm926ejs/mx28/mx28.c:150: +int do_mx28_showclocks(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
those iomux-mx28.h issues were already explained. It's a file taken from linux kernel with no modifications, that's why the issues. And if you take a look inside, fixing it would make it unreadable.
The error above appears to be unrelated. Why did you not fix at least these?
I believe the V3 should have that error fixed. The line-over-80 error that is.