On 12/12/2012 4:37 PM, Stefan Roese wrote:
On 12/06/2012 08:10 AM, Vipin Kumar wrote:
From: Shiraz Hashimshiraz.hashim@st.com
SPEAr310 and SPEAr320 Ethernet interfaces share same MDIO lines to control their respective phys. Currently their is a fixed configuration in which only a particular MAC can use the MDIO lines.
"there is" instead of "their is"
Thanks. I would change this in v2
Call an arch specific function to take control of specific mdio lines at runtime.
Signed-off-by: Shiraz Hashimshiraz.hashim@st.com Signed-off-by: Vipin Kumarvipin.kumar@st.com
drivers/net/macb.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 8bacbda..45fbbd7 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c @@ -163,6 +163,13 @@ static u16 macb_mdio_read(struct macb_device *macb, u8 reg) return MACB_BFEXT(DATA, frame); }
+static void __def_arch_get_mdio_control(const char *name) +{
- return;
+} +int arch_get_mdio_control(const char *name)
- __attribute__((weak, alias("__def_arch_get_mdio_control")));
__weak from linux/compiler.h please
in v2
Otherwise:
Acked-by: Stefan Roesesr@denx.de
Thanks, Stefan
Vipin