Scott Wood wrote:
On Thu, Nov 05, 2009 at 08:53:36AM +0000, kevin.morfitt@fearnside-systems.co.uk wrote:
This patch updates the s3c2410 nand driver from that of linux 2.6.31.5, modified to make it work in the u-boot mtd nand architecture and to allow setting the flash timing parameters from a board config file instead of being hard coded. Note that this modified driver supports s3c2410 and s3c2440.
Signed-off-by: Kevin Morfitt kevin.morfitt@fearnside-systems.co.uk
checkpatch.pl shows no errors or warnings, and MAKEALL ARM9 shows no new errors or warnings.
Tested on an Embest SBC2440-II Board with local s3c2440 patches as I don't have an s3c2410 board.
drivers/mtd/nand/s3c2410_nand.c | 134 +++++++++++++++++-------------- include/asm-arm/arch-s3c24x0/s3c2410.h | 25 ++++++ 2 files changed, 98 insertions(+), 61 deletions(-)
It looks like this got missed, probably because it either depended on something in (or destined for) the ARM tree, or I just assumed that because of the "PATCH ARM".
Unfortunately, it doesn't apply cleanly anymore. Could you resend, if it's still needed?
It was part of adding s3c2440 support which I've had to re-work quite a lot and is currently waiting for comments on a set of re-worked patches. I think it would be simpler if I dropped this one and submitted a replacement later on. I think the s3c2410 nand driver code is different in the u-boot main, Samsung SOC, and NAND repositories though so I'm not sure what I should base a future patch on given that Wolfgang asked me to always base patches on u-boot master.
-Scott