21 Jun
2007
21 Jun
'07
10:52 p.m.
In message ffc2b1d40706202307g63173ef6gd0caf19696ed4566@mail.gmail.com you wrote:
Signed-off-by: Eran Liberty
Patch exceed 40K and there is no logic in splitting it up. here is link which is good for one week.
You patch has many coding styyle issues: indentation not by TABs, trailing white space, excessive newlines, ...
Why are you adding compiler flags like -DCONFIG_EXSW6000=1 etc. to the PLATFORM_CPPFLAGS? This should not be necessary as these #defines are suppoosed tobe provided by your board config file. Please avoid such reduncancy.
Please cleanup and resubmit. Note that the link should be valid not only for a few days, otherwise chances are that we just lose it.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
There are some things worth dying for.
-- Kirk, "Errand of Mercy", stardate 3201.7