Re: [U-Boot] [PATCH v3 04/28] armv8/ls2085a: Fix generic timer clock source

diff --git a/arch/arm/cpu/armv8/fsl-lsch3/mp.c b/arch/arm/cpu/armv8/fsl-lsch3/mp.c index ce9c0c1..5338fe6 100644 --- a/arch/arm/cpu/armv8/fsl-lsch3/mp.c +++ b/arch/arm/cpu/armv8/fsl-lsch3/mp.c @@ -30,6 +30,13 @@ int fsl_lsch3_wake_seconday_cores(void) u32 cores, cpu_up_mask = 1; int i, timeout = 10; u64 *table = get_spin_tbl_addr(); +#ifdef COUNTER_FREQUENCY_REAL

• unsigned long cntfrq = COUNTER_FREQUENCY_REAL;
• __real_cntfrq = cntfrq; /* update for secondary cores */

Do you need the temporary cntfrq variable? Can't you just have:

__real_cntfrq = COUNTER_FREQUENCY_REAL;

• flush_dcache_range((unsigned long)&__real_cntfrq,

• 	   (unsigned long)&__real_cntfrq + 8);
  

This looks fine, as does the rest of the patch.

So either way:

Acked-by: Mark Rutland mark.rutland@arm.com

Thanks, Mark.