
22 Oct
2019
22 Oct
'19
12:18 p.m.
Subject: Re: [PATCH] imx: imx8: fix loading container image from eMMC boot partitions
On Tue, 22 Oct 2019 10:08:42 +0000 Peng Fan peng.fan@nxp.com wrote: ...
From common/spl/spl_mmc.c, there is boot partition switch there, Why need to add such logic in imx8/image.c?
spl_mmc_load() reads the container header before partition switching.
Oh. Indeeded. Not took care of emmc when adding
spl_mmc_get_uboot_raw_sector (:
I think we should avoid adding partition switching in get_container_size(), it looks like container header is read several times which is suboptimal. I'll have to rethink this patch, don't have time for this now.
ok. I'll give a look, if you not mind.
Thanks, Peng.
-- Anatolij