
7 Dec
2003
7 Dec
'03
8:40 p.m.
In message 71555548814716479478431542AA5F8A059042@dlee2k04.ent.ti.com you wrote:
This patch causes cmd_flash.c to report errors. There are several cases where the flash commands can return silently even if they fail. This is can lead to further problems.
Please don't re-invent the wheel. Instead of adding a new (IMHO ugly) implementation of an errpr printing function for flash errors (print_flash_error) you can use existing code (flash_perror).
Please cleanup and resubmit.
Best regards,
Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd@denx.de
Any sufficiently advanced technology is indistinguishable from magic.
- Arthur C. Clarke