Re: [PATCH v2 1/2] board: phytec: common: phytec_som_detection: Add phytec_get_som_type

On Mon, Mar 4, 2024 at 1:04 PM Benjamin Hahn B.Hahn@phytec.de wrote:

+enum phytec_som_type_str {

•   PCM = 0,
  

•   PCL,
  

•   KSM,
  

•   KSP,
  

+};

To avoid potential name clashes in the future, I suggest adding a prefix like:

SOM_TYPE_PCM = 0, SOM_TYPE_PCL, ...

static const char * const phytec_som_type_str[] = { "PCM", "PCL", @@ -67,5 +74,6 @@ void __maybe_unused phytec_print_som_info(struct phytec_eeprom_data *data);

char * __maybe_unused phytec_get_opt(struct phytec_eeprom_data *data); u8 __maybe_unused phytec_get_rev(struct phytec_eeprom_data *data); +u8 __maybe_unused phytec_get_som_type(struct phytec_eeprom_data *data);

#endif /* _PHYTEC_SOM_DETECTION_H */

-- 2.34.1