
Dear Wolfgang:
I believe that it is not setting any configuration information. In many boards the TEXT_BASE address is set up in the makefile depending if the user wants to compile u-boot for ram o for flash. Like the acadia (and many others)
@echo "TEXT_BASE = 0x01000000" > $(obj)board/amcc/acadia/config.tmp
I have no problem in setting the Makefile in the classic way, I just wanted to create a new way with the less code replication possible.
Shall I continue with this idea or I move back to the old way?
Regards
On Fri, Aug 29, 2008 at 07:41, Wolfgang Denk wd@denx.de wrote:
Dear Ricardo,
in message aa76a2be0808290416m4d030725oadef47643c90a8b2@mail.gmail.com you wrote:
ml507_flash_config: unconfig BOARD_DIR=$(obj)board/xilinx/ml507 \ TEXT_BASE=0xFE360000 \ LINK_SCRIPT=$(obj)board/xilinx/ppc440-generic/u-boot-rom.lds \ CONFIG_SCRIPT="ml507 ppc ppc4xx ml507 xilinx" \ $(MAKE) xilinx_ppc440
xilinx_ppc440: unconfig @mkdir -p $(obj)include $(BOARD_DIR) @cp $(LINK_SCRIPT) $(BOARD_DIR)/u-boot.lds @echo "TEXT_BASE = $(TEXT_BASE)" > $(BOARD_DIR)/config.mk @$(MKCONFIG) $(CONFIG_SCRIPT)
The Makefile is not the right place to provide configuration information. It shouls select a target board, and build it, nothing more.
All board specific configuration information should be kept in the board specific files only (please also keep in mind the next one who has to port Linux to a new board - config information should not be scattered over too many polaces, and especially no into common , central files).
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Change is the essential process of all existence. -- Spock, "Let That Be Your Last Battlefield", stardate 5730.2