Subject: Re: [PATCH V2] cpu: imx8_cpu: Avoid revision to corrupt device tree
On Thu, Oct 17, 2024 at 4:08 AM Peng Fan (OSS) peng.fan@oss.nxp.com wrote:
From: Peng Fan peng.fan@nxp.com
U-Boot device tree is padded just after U-Boot proper. After the whole stuff loaded to DRAM space, the device tree area is conflict with BSS region before U-Boot relocation.
So any write to BSS area before reloc_fdt will corrupt the device tree. Without the fix, there is issue that “binman_init failed:-2” on i.MX8MP-EVK board.
Signed-off-by: Peng Fan peng.fan@nxp.com
V2: move the rev to malloc area in cpu_imx_plat tested on i.MX8MP
EVK
Please adapt the commit log to include this information.
This patch breaks CI. Make sure to run all your patches through CI:
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F source.denx.de%2Fu-boot%2Fcustodians%2Fu-boot-imx%2F- %2Fjobs%2F920875&data=05%7C02%7Cpeng.fan%40nxp.com%7C385 8971a1966454c3c5c08dceeaa4b47%7C686ea1d3bc2b4c6fa92cd99c5 c301635%7C0%7C0%7C638647662428479157%7CUnknown%7CTWF pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWw iLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=AcYrq2JFg1BPegpK18%2 B7KsaD4ZoxIAqGX8ZYlGmUB2o%3D&reserved=0
aarch64: + imx8qm_rom7720_a1_4G 321+WARNING 'mx8qm-ahab-container.img' not found, resulting binary is not-functional 322+drivers/cpu/imx8_cpu.c: In function 'get_imx_rev_str': 323+drivers/cpu/imx8_cpu.c:78:17: error: 'rev' is used uninitialized [-Werror=uninitialized] 324+ 78 | switch (rev) { 325+ | ^~~~~~ 326+drivers/cpu/imx8_cpu.c:76:22: note: 'rev' was declared here 327+ 76 | char rev; 328+ | ^~~ 329+cc1: all warnings being treated as errors
I am getting too much extra work to process the patches from NXP folks and I am not happy with it.
Sorry for this. I was too confident with the patch (: I will take care.
-Peng.