Re: [PATCH v2 4/6] binman: capsule: Use dumped capsule header contents for verification

On Tue, 10 Oct 2023 at 02:12, Sughosh Ganu sughosh.ganu@linaro.org wrote:

The various fields of a generated capsule are currently verified through hard-coded offsets. Use the dump-capsule feature for dumping the capsule header contents and use those for capsule verification.

Signed-off-by: Sughosh Ganu sughosh.ganu@linaro.org

Changes since V1:

• Move the get_binman_test_guid() function outside the Entry_efi_capsule class so that it can be called from outside the module.
• Use lowercase characters in the GUID values
• Add comments for the _GetCapsuleHeaders() function.
• Use a simple dict in _GetCapsuleHeaders() for storing the capsule header values dumped by the mkeficapsule tool.

tools/binman/etype/efi_capsule.py | 24 +++++-- tools/binman/ftest.py | 105 ++++++++++++++++++------------ 2 files changed, 82 insertions(+), 47 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org

Applied to u-boot-dm, thanks!