Dear Mike Frysinger,
On Thursday 05 April 2012 06:13:21 Marek Vasut wrote:
Dear Mike Frysinger,
Building usb for Blackfin boards fails as we get linux/compiler.h included which expands the "noinline" inside of the attribute and we get attribute(attribute(noinline)).
Explicitly use the helper define to avoid this.
Ain't compiler.h broken then?
no ... why would it be ?
Because it colides with gcc stuff?
Btw. is this a fix I should push to .04 release?
i looked closer at how exactly it's failing, and i think waiting for the next merge window is OK if you want
I'm fine either way as I don't observe this. On the other hand, I'd be inclined to push this into current release if you're 100% sure about the fix and it fixes real issue for some people.
-mike
Best regards, Marek Vasut