Dear Prafulla Wadaskar,
-----Original Message----- From: Marek Vasut [mailto:marex@denx.de] Sent: 21 March 2012 12:52 To: Luka Perkov Cc: u-boot@lists.denx.de; dreagle@doukki.net; Wolfgang Denk; Prafulla Wadaskar Subject: Re: [U-Boot] [PATCH v2] add new board nas62x0
Dear Luka Perkov,
Hi Marek,
...snip...
This is my proposal - I'll resend v4 and it should be ok to
commit
without fixes for:
- IB62x0_OE_LOW and IB62x0_OE_HIGH
- CONFIG_SKIP_LOWLEVEL_INIT
- ifdef indentation
Because fixing the 1) and 2) is more than adding support for
this new
board, and if it was in the same patch I would need to separate
it.
That is a different issue.
You can wait for Prafulla with #1 and #2, also for #2 check my
comment.
But we have two bugs going on for granted here at least and
they're not
your boards fault. On the other hand, it'd be cool if you could
fix them
prior to adding your board ;-)
Hi Luka
#1: Defining these values as 0xffffffff, indicates that all GPIOs are configured high by default. so this configuration solely depends upon your board requirement.
#2: on kirkwood, you should define CONFIG_SKIP_LOWLEVEL_INIT since lowlevel_init is not needed on Kirkwood platforms. (ref: doc/README.kwbimage)
Prafulla, you're then missing the fiddling with CPSR bits, which might be quite necessary.
Regards.. Prafulla . . .
Best regards, Marek Vasut