Re: [U-Boot] [PATCH v2] spi: add new driver for OpenCores tiny_spi

Dear Thomas Chou,

In message 1294626279-8601-1-git-send-email-thomas@wytron.com.tw you wrote:

This patch adds support for OpenCores tiny_spi.

http://opencores.org/project,tiny_spi

Signed-off-by: Thomas Chou thomas@wytron.com.tw

for u-boot v2, use const and clean up as Mike suggested.

...

+void spi_cs_activate(struct spi_slave *slave) +{

• struct tiny_spi_slave *tiny_spi = to_tiny_spi_slave(slave);
• unsigned int cs = slave->cs;
• gpio_set_value(cs, tiny_spi->flg);
• debug("%s: SPI_CS_GPIO:%x\n", __func__, gpio_get_value(cs));

+}

Please separate declartations and code with a blank line. Please fix globally.

...

+int spi_claim_bus(struct spi_slave *slave) +{

• struct tiny_spi_slave *tiny_spi = to_tiny_spi_slave(slave);
• const struct tiny_spi_host *host = tiny_spi->host;
• debug("%s: bus:%i cs:%i\n", __func__, slave->bus, slave->cs);
• gpio_direction_output(slave->cs, !tiny_spi->flg);
• writel(tiny_spi->mode, host->base + TINY_SPI_CONTROL);
• writel(tiny_spi->baud, host->base + TINY_SPI_BAUD);

Please do not use base + offset notation. Use a proper C struct instead. Please fix globally.

Best regards,

Wolfgang Denk