In message 20030814154333.GD1468@buici.com you wrote:
The other change appears below. For some reason, the existing IDE code reorders the half-words of the capacity value read from the IDE device. I don't have any MSB CPUs, so I cannot verify the need for this. AFAICT, it should not be necessary.
Well, I have no LE CPU's where I can test a CF card easily.
But I can say that the current code works fine of PPC systems.
I'd make the conditional test hinge on endianness if I knew that was the reason for the swapping. So, either we add an __X86__ check, or we change the conditional.
@@ -1056,7 +1099,12 @@ #endif /* CONFIG_ATAPI */
/* swap shorts */+#if !defined (__ARM__)
I will reject such a patch. This is definitely not an ARM / not ARM issue.
+#else
/* elf: it isn't clear why this code swaps the words. There's nothing i
This comment puzzles me: what's "elf"? ELF file format??
Best regards,
Wolfgang Denk