Am 2022-02-22 15:47, schrieb Heiko Thiery:
With the correct settings described in the device-tree the PHY settings in the board init are no longer required. The values are taken from the linux device tree.
Suggested-by: Michael Walle michael@walle.cc Signed-off-by: Heiko Thiery heiko.thiery@gmail.com
arch/arm/dts/imx8mn-evk.dtsi | 9 +++++++++ board/freescale/imx8mn_evk/imx8mn_evk.c | 16 ---------------- 2 files changed, 9 insertions(+), 16 deletions(-)
diff --git a/arch/arm/dts/imx8mn-evk.dtsi b/arch/arm/dts/imx8mn-evk.dtsi index 416fadb22b..4453a1a281 100644 --- a/arch/arm/dts/imx8mn-evk.dtsi +++ b/arch/arm/dts/imx8mn-evk.dtsi @@ -64,6 +64,15 @@ ethphy0: ethernet-phy@0 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <0>;
reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
u-boot already has this property in the fec node. So it is now duplicated.
Both properties are documented in the bindings spec and it seems u-boot also supports both. So to be aligned with the linux dtb, I guess it should be kept here and the one in the fec node should be removed (?).
-michael