21 Sep
2009
21 Sep
'09
10:34 a.m.
Dear Peter Tyser,
In message 1253489072.27060.51.camel@ptyser-laptop you wrote:
- JOBS=-j`expr "$BUILD_NCPUS" + 1`
- JOBS="-j $(($BUILD_NCPUS + 1))"
...
This is an unrelated change. I would not include it with this patch.
Mike mentioned using POSIX math in the new arithmetic functions I added, which makes sense. I reasoned it was better to convert the 1 other reference to 'expr + 1' to the same POSIX style for consistency's sake. Changing 1 'expr + 1' reference to $((+ 1)) doesn't seem worth its own commit, so I rolled it into this patch. How about I just add a sentence to the commit message stating that I also converted math operations to be POSIX compliant?
It's still an unrelated change. Please do this in a separate patch (probably before adding your other changes).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"More software projects have gone awry for lack of calendar time than
for all other causes combined."
- Fred Brooks, Jr., _The Mythical Man Month_