On Thu, Oct 18, 2012 at 10:51:47PM +0400, Ilya Yanok wrote:
Current MUSB driver in U-Boot uses old UDC API while new gagdet client drivers need new gadget API. Also current MUSB driver has some significant limitations (like inability to handle tx for endpoints other than ep0). So I think port of new Linux driver is desirable.
This is initial port, performed mostly by putting DM and OTG code under #ifndef __UBOOT__ clauses. My intention was to be as close as possible to the original to ease of possible resyncs. Some warnings are suppressed via CFLAGS. There are some style problems but I'm not touching them for now for the above mentioned reason. There is obviously some room for optimisation, some structure fields are unused as well as (probably) some code.
This is a fine way to go.
This is not a replacement for existing MUSB driver (at least for now), cause there are still consumers of USB serial gadget which uses old API and there is no support for serial with new API for now.
I'm a little lost. In the kernel, you can't use CONFIG_USB_G_SERIAL with CONFIG_USB_MUSB_${hw glue} ?
In general, things look OK but please run it through checkpatch.pl, use just one Signed-off-by line and fixup if (...) { ... one line ... } in the glue code you add that's not synced up from the kernel (I saw one in the am335x bits). Thanks! And lets move this out of RFC...