Re: [U-Boot] [PATCH v8 3/4] mpc83xx: Add a GPIO driver for the MPC83XX family

On Friday 04 November 2011 22:25:00 Joe Hershberger wrote:

--- /dev/null +++ b/arch/powerpc/include/asm/arch-mpc83xx/gpio.h

+#if defined(CONFIG_MPC8313) || defined(CONFIG_MPC8308) || \

• 		defined(CONFIG_MPC8315)
  

• #define MPC83XX_GPIO_CTRLRS 1

+#elif defined(CONFIG_MPC834x) || defined(CONFIG_MPC837x)

• #define MPC83XX_GPIO_CTRLRS 2

+#else

• #define MPC83XX_GPIO_CTRLRS 0

+#endif

there should not be whitespace before the "#"

--- /dev/null +++ b/drivers/gpio/mpc83xx_gpio.c

+#ifndef CONFIG_MPC83XX_GPIO_0_INIT_DIRECTION

• #define CONFIG_MPC83XX_GPIO_0_INIT_DIRECTION 0

+#endif +#ifndef CONFIG_MPC83XX_GPIO_1_INIT_DIRECTION

• #define CONFIG_MPC83XX_GPIO_1_INIT_DIRECTION 0

+#endif +#ifndef CONFIG_MPC83XX_GPIO_0_INIT_OPEN_DRAIN

• #define CONFIG_MPC83XX_GPIO_0_INIT_OPEN_DRAIN 0

+#endif +#ifndef CONFIG_MPC83XX_GPIO_1_INIT_OPEN_DRAIN

• #define CONFIG_MPC83XX_GPIO_1_INIT_OPEN_DRAIN 0

+#endif +#ifndef CONFIG_MPC83XX_GPIO_0_INIT_VALUE

• #define CONFIG_MPC83XX_GPIO_0_INIT_VALUE 0

+#endif +#ifndef CONFIG_MPC83XX_GPIO_1_INIT_VALUE

• #define CONFIG_MPC83XX_GPIO_1_INIT_VALUE 0

+#endif

same here -mike