Hi Stefan,
On 25/07/2014 16:50, Stefan Roese wrote:
On 25.07.2014 15:27, Gerald Kerma wrote:
This patch add Marvell kirkwood MVSDIO/MMC driver and enable it for Sheevaplugs and OpenRD boards.
Signed-off-by: Gerald Kerma drEagle@doukki.net
Please don't send this patch as base64 encoded. It makes it impossible to apply this patch or run checkpatch on it.
I use git send-email and I have used the default encoding [UTF-8], what is the preferred format that I may specify ?
Did you run it though checkpatch btw?
yes, the results given is : total: 0 errors, 0 warnings, 0 checks, 744 lines checked
Same for the coming v6 on 730 lines checked.
I suggest to rename the driver to mvebu_mmc.c instead. This MVEBU is the generally agreed upon abbreviation for Marvell SoC's (Orion, Kirkwood, Armada XP, 370 ...).
Done,
Doesn't it make sense to move this code to init / enable the MMC driver into the arch/cpu/... SoC code? Instead of adding it to all the board specific files?
Good idea
Here we have this code again. I suggest to move it to the kirkwood cpu.c file instead.
Done
I'll check and send a new version (v6). Do I rename the patch header ?
Enjoy