Hi Tom, Simon,
On Wed, Sep 25, 2019 at 02:42:03PM -0600, Simon Glass wrote:
Hi Lukasz,
On Tue, 17 Sep 2019 at 15:06, Lukasz Majewski lukma@denx.de wrote:
On Tue, 17 Sep 2019 14:19:33 -0500 Adam Ford aford173@gmail.com wrote:
On Tue, Sep 17, 2019 at 1:34 PM Simon Glass sjg@chromium.org wrote:
Hi Lukasz,
On Tue, 17 Sep 2019 at 00:22, Lukasz Majewski lukma@denx.de wrote:
Hi Simon,
> On Sun, 18 Aug 2019 at 19:30, Peng Fan peng.fan@nxp.com > wrote: > > > > > Subject: [PATCH v2 8/9] spl: Introduce SPL_DM_GPIO > > > Kconfig define > > > > > > This define indicates if DM_GPIO shall be supported > > > in SPL. This allows proper operation of DM converted > > > GPIO drivers in SPL, which use #if > > > !CONFIG_IS_ENABLED(DM_GPIO) to also support not yet > > > DM/DTS converted boards.
Many of the drivers list the SPL_DM options under their respective heading. For example, SPL_DM_USB is under the USB menu right next to the option to select CONFIG_DM_USB. If we're going to add the option to separate DM_GPIO from SPL_DM_GPIO, I would suggest following that pattern and place it in the GPIO menu so they are next to each other and make the dependency obvious.
For the current patch I've followed the pattern and added SPL_DM_GPIO to the "spl" submenu of menuconfig.
And as I've written in the other mail - I think that SPL_DM_GPIO shall depend on DM_GPIO.
Considering the above - shall I place SPL_DM_GPIO next to DM_GPIO section or to the "spl" submenu?
That makes sense to me. At some point we should change them all.
+Tom Rini for comment too
Should we get consistent? Yes. One of our not yet solved well enough problems is what are we going to do about SPL/TPL, image size and conflicting requirements. For now I think having these options be in the spl menu makes some future shuffling easier to do.
Ok. So I will add SPL_DM_GPIO to spl menu and make it dependent on DM_GPIO.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de