Mike Frysinger wrote:
On Monday, February 28, 2011 13:50:55 Michal Simek wrote:
Mike Frysinger wrote:
On Monday, February 28, 2011 04:40:33 Michal Simek wrote:
- return 1;
a bunch of these funcs return 1 when i'm pretty sure they should be 0
init function is called from eth.c:eth_init(). From the code below you see that return can be >=0.
funny enough, that func in your patch is returning 0 when it should be 1. it doesnt explain why your recv/send are returning 1 when it should be 0.
BTW: blackin emac recv functions return 0, -1 and length values. Is it correct?
static int bfin_EMAC_recv(struct eth_device *dev) { int length = 0;
for (;;) { if ((rxbuf[rxIdx]->StatusWord & RX_COMP) == 0) { length = -1; break; } ... return length; }
Michal