Re: [PATCH v6 3/3] led: Add dts property to specify blinking of the led

On Fri, 19 Jul 2024 at 10:12, Mikhail Kshevetskiy mikhail.kshevetskiy@iopsys.eu wrote:

From: Michael Polyntsov michael.polyntsov@iopsys.eu

The standard property

linux,default-trigger = "pattern";

used to get an effect. No blinking parameters can be set yet.

Signed-off-by: Michael Polyntsov michael.polyntsov@iopsys.eu Signed-off-by: Mikhail Kshevetskiy mikhail.kshevetskiy@iopsys.eu

---

drivers/led/led-uclass.c | 30 +++++++++++++++++++++++++----- 1 file changed, 25 insertions(+), 5 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org

One more thing - it should really have a test, like dm_test_led_blink(), some ideas about how to fiddle the time are in dm_test_rtc_set_get().