Re: [PATCH] serial: ns16550: Enable clocks during probe

On 11/28/22 06:48, Samuel Holland wrote:

If the UART bus or baud clock has a gate, it must be enabled before the UART can be used.

Signed-off-by: Samuel Holland samuel@sholland.org

drivers/serial/ns16550.c | 5 +++++ 1 file changed, 5 insertions(+)

diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index 7592979cab5..785fb520062 100644 --- a/drivers/serial/ns16550.c +++ b/drivers/serial/ns16550.c @@ -506,6 +506,7 @@ int ns16550_serial_probe(struct udevice *dev) struct ns16550_plat *plat = dev_get_plat(dev); struct ns16550 *const com_port = dev_get_priv(dev); struct reset_ctl_bulk reset_bulk;

• struct clk_bulk clk_bulk; fdt_addr_t addr; int ret;

@@ -524,6 +525,10 @@ int ns16550_serial_probe(struct udevice *dev) if (!ret) reset_deassert_bulk(&reset_bulk);

• ret = clk_get_bulk(dev, &clk_bulk);
• if (!ret)

• clk_enable_bulk(&clk_bulk);
  

• com_port->plat = dev_get_plat(dev); ns16550_init(com_port, -1);

Reviewed-by: Stefan Roese sr@denx.de

Thanks, Stefan