Re: [U-Boot] [PATCH v4 1/2][NEXT] davinci_emac: davinci_eth_set_mac_addr to ->write_hwaddr

On Thu, Sep 23, 2010 at 5:03 AM, Nick Thompson nick.thompson@ge.com wrote:

davinci_eth_set_mac_addr() always returns zero, so "if (!dev->write_hwaddr(dev))" always appears to fail here.

In net/eth.c the return code is not checked, so da830 should probably ignore it to:

You're absolutely right, Nick. Thanks for the review and testing; patch coming.

Best Regards, Ben Gardiner

--- Nanometrics Inc. http://www.nanometrics.ca