Hi Richard,
Detlev Zundel wrote:
<snip> > > Please excuse my ignorance, but why not simply remove the #ifdef > CONFIG_AMIGAONEG3SE in board_init_f? Actually I was hoping to remove > the Amigaone special case. > > Cheers > Detlev > I prefer getting the data from board_init_r because we really are running from RAM at that point; dest_addr is a passed in function param.
I see, thanks for the explanation.
In board_init_f, the addr variable is just what the calculated address is. If we must do the copy there I'd like to move the gd->relocaddr = addr to just before the call to relocate_code, that way if the calculation code got reworked/refactored, we always copy the correct addr variable.
Yes, I also agree - if we want to have it in _f, we should move the assignment.
Plus the line: debug ("Now running in RAM - U-Boot at: %08lx\n", dest_addr);
in board_init_r
This printout is so useful that it should have its own config option so one can have it always on without enabling debug.
Jocke