Re: [U-Boot] [PATCH] spi: cadence_qspi: Fix checking return value of fdt_first_subnode()

On 7 January 2015 at 07:24, Axel Lin axel.lin@ingics.com wrote:

fdt_first_subnode() returns -FDT_ERR_NOTFOUND if no subnode found. 0 is supposed to be a valid offset returns from fdt_first_subnode().

Signed-off-by: Axel Lin axel.lin@ingics.com

drivers/spi/cadence_qspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c index fa95b19..98ae3b8 100644 --- a/drivers/spi/cadence_qspi.c +++ b/drivers/spi/cadence_qspi.c @@ -297,7 +297,7 @@ static int cadence_spi_ofdata_to_platdata(struct udevice *bus)

    /* All other paramters are embedded in the child node */
    subnode = fdt_first_subnode(blob, node);

•   if (!subnode) {
  

•   if (subnode < 0) {
            printf("Error: subnode with SPI flash config missing!\n");
            return -ENODEV;
    }
  

-- 1.9.1

Applied to u-boot-spi/master

thanks!