Re: [PATCH V2] net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY

29 Jan 2021


      On 1/29/21 5:19 PM, Oleksandr Suvorov wrote:
...
Hi Marek,
Hi,
[...]
...
...
+++ b/arch/arm/dts/fsl-imx8qm-apalis.dts
@@ -503,7 +503,7 @@
         pinctrl-0 = <&pinctrl_fec1>;
         fsl,magic-packet;
         phy-handle = <&ethphy0>;

  phy-mode = "rgmii";




  phy-mode = "rgmii-id";



The PHY on Apalis iMX8QM expects the delay on TXC line only.
So "rgmii-txid" would be better there.
Can you prepare me a tested diff for the apalis boards so I can squash 
it into V3 ? That would be easiest.
[...]
...
...
/* Networking */
-#define FEC_QUIRK_ENET_MAC
This quirk can't be dropped so far.
With the following patch applied, I believe it can:
[PATCH] ARM: imx: Add missing FEC ethernet quirk for MX8M
[...]

    

Marek Vasut