Re: [U-Boot] [PATCH 1/1] efi_selftest: correctly check return values

On 13 October 2017 at 01:00, Heinrich Schuchardt xypron.glpk@gmx.de wrote:

When cancelling the timer we should check the return value provided by the set_timer service.

Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de

lib/efi_selftest/efi_selftest_events.c | 2 +- lib/efi_selftest/efi_selftest_tpl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org

Although I favour:

if (ref)

instead of:

if (ret != EFI_SUCCESS)

0 is the standard value for success in U-Boot.

Regards, Simon