
11 Jul
2008
11 Jul
'08
11:55 a.m.
John Ogness wrote:
I've changed the patch so that it is less intrusive. It now simply adds the new function to the "init_sequence" if defined.
Signed-off-by: John Ogness john.ogness@linutronix.de
Could you please send your patches inline next time to simplify reviewing? Thanks.
I have a general remark here. Currently, various 85xx boards setup the local bus in the board specific code called from checkboard(). Your set_lbc_clock_ratio() would be called earlier and is therefore unusable for these board. Nevertheless, the setting of the clock rate is just one thing to be done to setup the local bus properly but there are more including bug fixes. I would appreciate a generic function for that purpose to get rid of duplicated code.
Wolfgang.