Re: [U-Boot] [PATCH v4 04/10] Add fsl_iim driver

On 23/04/2013 22:17, Benoît Thébaudeau wrote:

Add a fsl_iim driver common to i.MX and MPC.

Signed-off-by: Benoît Thébaudeau benoit.thebaudeau@advansee.com

Changes in v4:

• Remove the bit interface.
• Fix the checkpatch warning about the usage of volatile.
• Remove useless quotes in #error.
• Unsplit long error messages for grep-ability.
• Remove useless #include-s.
• Drop CONFIG_SYS_FSL_IIM_ADDR.
• Use iim_setbits32() where appropriate.
• Create helper functions to remove duplicate code and to improve code readability.

Changes in v3:

• Update copyright years.
• Rename "row" to "word" since it is less confusing and it is vocabulary common to iim and ocotp in the reference manuals.
• Add doc/README.fsl_iim.

Changes in v2:

• Rebase against latest master.

arch/arm/include/asm/arch-mx25/imx-regs.h | 1 + arch/arm/include/asm/arch-mx27/imx-regs.h | 1 + arch/arm/include/asm/arch-mx31/imx-regs.h | 1 + arch/powerpc/include/asm/immap_512x.h | 2 + doc/README.fsl_iim | 48 +++++ drivers/misc/Makefile | 1 + drivers/misc/fsl_iim.c | 286 +++++++++++++++++++++++++++++ 7 files changed, 340 insertions(+) create mode 100644 doc/README.fsl_iim create mode 100644 drivers/misc/fsl_iim.c

Applied to u-boot-imx, thanks.

Best regards, Stefano Babic