Hi Dang,
On 2025/1/16 17:15, Dang Huynh wrote:
HDMI on RK3568 is mostly simplified, all this does is enabling DDC for display timings and HPD.
Signed-off-by: Dang Huynh danct12@riseup.net
drivers/video/rockchip/Makefile | 1 + drivers/video/rockchip/rk3568_hdmi.c | 63 ++++++++++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+)
diff --git a/drivers/video/rockchip/Makefile b/drivers/video/rockchip/Makefile index 2f89a979a2848733be5a6d05817ad76ce3ad3a34..b751c969b46f1933e91a6c0434f31227a709d8e5 100644 --- a/drivers/video/rockchip/Makefile +++ b/drivers/video/rockchip/Makefile @@ -14,6 +14,7 @@ obj-$(CONFIG_DISPLAY_ROCKCHIP_LVDS) += rk_lvds.o obj-hdmi-$(CONFIG_ROCKCHIP_RK3288) += rk3288_hdmi.o obj-hdmi-$(CONFIG_ROCKCHIP_RK3328) += rk3328_hdmi.o obj-hdmi-$(CONFIG_ROCKCHIP_RK3399) += rk3399_hdmi.o +obj-hdmi-$(CONFIG_ROCKCHIP_RK3568) += rk3568_hdmi.o obj-$(CONFIG_DISPLAY_ROCKCHIP_HDMI) += rk_hdmi.o $(obj-hdmi-y) obj-mipi-$(CONFIG_ROCKCHIP_RK3288) += rk3288_mipi.o obj-mipi-$(CONFIG_ROCKCHIP_RK3399) += rk3399_mipi.o diff --git a/drivers/video/rockchip/rk3568_hdmi.c b/drivers/video/rockchip/rk3568_hdmi.c new file mode 100644 index 0000000000000000000000000000000000000000..e0dae919c89d685c145373c8520c52c760f60864 --- /dev/null +++ b/drivers/video/rockchip/rk3568_hdmi.c @@ -0,0 +1,63 @@ +// SPDX-License-Identifier: GPL-2.0+ +/*
- Copyright (c) 2024 Dang Huynh danct12@riseup.net
- */
+#include <display.h> +#include <dm.h> +#include <dw_hdmi.h> +#include <edid.h> +#include <asm/arch-rockchip/hardware.h> +#include <asm/arch-rockchip/grf_rk3568.h> +#include "rk_hdmi.h"
+#define RK3568_IO_DDC_IN_MSK ((3 << 14) | (3 << (14 + 16)))
+static int rk3568_hdmi_enable(struct udevice *dev, int panel_bpp,
const struct display_timing *edid)+{
- struct rk_hdmi_priv *priv = dev_get_priv(dev);
- return dw_hdmi_enable(&priv->hdmi, edid);
+}
+static int rk3568_hdmi_of_to_plat(struct udevice *dev) +{
- struct rk_hdmi_priv *priv = dev_get_priv(dev);
- struct dw_hdmi *hdmi = &priv->hdmi;
- hdmi->i2c_clk_high = 0x71;
- hdmi->i2c_clk_low = 0x76;
- return rk_hdmi_of_to_plat(dev);
+}
+static int rk3568_hdmi_probe(struct udevice *dev) +{
- struct rk_hdmi_priv *priv = dev_get_priv(dev);
- struct rk3568_grf *grf = priv->grf;
- writel(RK3568_IO_DDC_IN_MSK, &grf->vo_con1);
- return rk_hdmi_probe(dev);
+}
+static const struct dm_display_ops rk3568_hdmi_ops = {
- .read_edid = rk_hdmi_read_edid,
- .enable = rk3568_hdmi_enable,
+};
+static const struct udevice_id rk3568_hdmi_ids[] = {
- { .compatible = "rockchip,rk3568-dw-hdmi" },
- { }
+};
+U_BOOT_DRIVER(rk3568_hdmi_rockchip) = {
- .name = "rk3568_hdmi_rockchip",
- .id = UCLASS_DISPLAY,
- .of_match = rk3568_hdmi_ids,
- .ops = &rk3568_hdmi_ops,
- .of_to_plat = rk3568_hdmi_of_to_plat,
- .probe = rk3568_hdmi_probe,
- .priv_auto = sizeof(struct rk_hdmi_priv),
+};
Enable the "avdd-0v9" and "avdd-1v8" regulators as we did in the Kernel is a good idea.