Re: [U-Boot] [PATCH] ppc4xx/POST: Change ethernet test loop count from 192 to 16

Dear Stefan Roese,

In message 201011261627.25617.sr@denx.de you wrote:

I don't like this "l+=91" statement. How about making it a bit more flexible. Something like this:

#define MIN_PACKET_LENGTH 64 #define MAX_PACKET_LENGTH 1518 #ifndef CONFIG_SYS_POST_ETH_LOOPS #define CONFIG_SYS_POST_ETH_LOOPS 10 #endif #define PACKET_INCR ((MAX_PACKET_LENGTH - MIN_PACKET_LENGTH) / \ CONFIG_SYS_POST_ETH_LOOPS)

Agreed. For the final version, please check how MAX_PACKET_LENGTH is used (I didn't do this) and verify that 1518 is the correct value to use here.

Thanks.

Best regards,

Wolfgang Denk