Hi,
On 07/28/2014 10:09 AM, thomas.langer@lantiq.com wrote:
Hello Hans,
Hans de Goede wrote on 2014-07-27:
On some boards the phy needs to be powered up through a gpio, add support for this.
@@ -129,6 +129,11 @@ int cpu_eth_init(bd_t *bis) { __maybe_unused int rc; +#ifdef CONFIG_MACPWR
If this is powering a phy, maybe CONFIG_PHYPWR or similar is a better name? Because PHY and MAC are different things!
True, but there can be many kinds of PHYs usb phys, ahci phys, ethernet phys, etc.
And maybe adding GPIO to the name to indicate that the value is a GPIO number?
The current name mirrors the AHCIPWR setting we already for ahci support on sinxi boards.
All of these should be part of the description in the README, which each CONFIG_ option requires.
That is a good point. We've not documented any of the sunxi specific options as of yet. Since we've quite a few I think it might be better to add a new doc/README.sunxi file for this. I've put creating such a file on my todo list.
Regards,
Hans