Hi Ian,
On 09/28/2014 05:33 PM, Ian Campbell wrote:
On Thu, 2014-09-25 at 20:09 +0100, Ian Campbell wrote:
On Wed, 2014-09-24 at 16:01 +0800, Chen-Yu Tsai wrote:
The Colombus board is an A31 evaluation board from WITS Technology.
Signed-off-by: Chen-Yu Tsai wens@csie.org
configs/Colombus_defconfig | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 configs/Colombus_defconfig
diff --git a/configs/Colombus_defconfig b/configs/Colombus_defconfig new file mode 100644 index 0000000..16800de --- /dev/null +++ b/configs/Colombus_defconfig @@ -0,0 +1,4 @@ +CONFIG_SYS_EXTRA_OPTIONS="COLOMBUS"
Does this do anything other than define an unused #define?
Ah, I suppose eventually it will cause the inclusion of a suitable dram file. Really ought to start moving things out of SYS_EXTRA though, but I don't think you need to shave that yakk just to get this patch in, so:
Acked-by: Ian Campbell ijc@hellion.org.uk
Although I've just noticed that lacks a board/sunxi/MAINTAINERS entry.
I think there is no need to resend the whole series, just this one patch. With this minor tweak I think it's time add this to u-boot-sunxi#next.
Before you do that, note that I've just added 2 patches there, which I would like to get into v2014.10. Specifically I'm hoping that I can get some positive testing feedback on the bananapi gmac patch I've send (off-list), and I believe we really should try to get the bananapi fix into v2014.10, and if we're going todo a pull-req for v2014.10, we might as well include the 2 patches I've just added to next. Do you agree ?
Still feel free to merge the sun6i series into next, I can just cherry pick the 3 patches in question directly into master when I'm ready to send the pull-req.
Regards,
Hans