Re: [U-Boot] [PATCH] get_ram_size: memory content of base address was not restored

Dear ratbert.chuang@gmail.com,

In message 1274771093-29677-1-git-send-email-ratbert.chuang@gmail.com you wrote:

From: Po-Yu Chuang ratbert@faraday-tech.com

Signed-off-by: Po-Yu Chuang ratbert@faraday-tech.com

common/memsize.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/common/memsize.c b/common/memsize.c index 6c275c9..99469ab 100644 --- a/common/memsize.c +++ b/common/memsize.c @@ -74,6 +74,7 @@ long get_ram_size(volatile long *base, long maxsize) return (0); }

•   *addr = save[i];
    for (cnt = 1; cnt < maxsize / sizeof (long); cnt <<= 1) {
            addr = base + cnt;      /* pointer arith! */
            val = *addr;
  

I think this patch is wrong. The value at address (base + 0) is never saved, so there is no need to restore it (nor did we store it's value anywhere).

Best regards,

Wolfgang Denk